Refactor Py2NRNString.
#3249
Merged
Refactor Py2NRNString.
#3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ 9d6872b -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
matz-e
reviewed
Nov 26, 2024
1uc
force-pushed
the
1uc/refactor-py2nrnstring
branch
from
9d6872b to
c6523a2
Compare
|
✔️ c6523a2 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
alkino
approved these changes
Nov 27, 2024
1uc
force-pushed
the
1uc/refactor-py2nrnstring
branch
from
c6523a2 to
fe213e8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3249 +/- ##
==========================================
- Coverage 67.07% 67.06% -0.01%
==========================================
Files 571 571
Lines 111110 111070 -40
==========================================
- Hits 74528 74492 -36
+ Misses 36582 36578 -4 ☔ View full report in Codecov by Sentry. |
|
✔️ fe213e8 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
1uc
force-pushed
the
1uc/refactor-py2nrnstring
branch
from
8e5f96e to
62ffda0
Compare
|
|
✔️ 62ffda0 -> Azure artifacts URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Py2NRNStringconsisted of (what's now) aunique_cstr. The ctor would create the cstr, and{g,s}et_pyerrwere non-static methods. They needed to check if the cstr as anullptr, but where only ever called after checking that it was anullptr.This commit separates several notions:
unique_cstr.as_ascii.{g,s}et_pyerrwere made static an are independent of each other and from converting a Python object to an (ASCII) C-string.PyErr2NRNStringwas removed.